Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/212#discussion_r225719987
  
    --- Diff: 
src/java/org/apache/cassandra/net/StartupClusterConnectivityChecker.java ---
    @@ -73,56 +80,84 @@ public static StartupClusterConnectivityChecker 
create(int targetPercent, int ti
          * @return true if the requested percentage of peers are marked ALIVE 
in gossip and have their connections opened;
          * else false.
          */
    -    public boolean execute(Set<InetAddressAndPort> peers)
    +    public boolean execute(Set<InetAddressAndPort> peers, 
Function<InetAddressAndPort, String> getDatacenter)
         {
    -        if (targetPercent == 0 || peers == null)
    +        if (peers == null)
    --- End diff --
    
    This change appears to remove the ability to disable this? It's an 
interesting change because it means we will always prime the connections which 
sounds kind of useful.
    
    The most you can do is crank down the timeout or set the number of hosts 
you won't wait for very high which has a similar impact.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to