Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/279#discussion_r226129803
  
    --- Diff: 
test/burn/org/apache/cassandra/utils/memory/LongBufferPoolTest.java ---
    @@ -181,7 +222,7 @@ void checkpoint()
                     void testOne() throws Exception
                     {
     
    -                    long currentTargetSize = rand.nextInt(poolSize / 1024) 
== 0 ? 0 : targetSize;
    +                    long currentTargetSize = (rand.nextInt(poolSize / 
1024) == 0 || freedAllMemory[threadIdx].get() == false) ? 0 : targetSize;
    --- End diff --
    
    ```suggestion
                        long currentTargetSize = (rand.nextInt(poolSize / 1024) 
== 0 || !freedAllMemory[threadIdx].get()) ? 0 : targetSize;
    ```
    
    This is the canonical way in Java.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to