Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/212#discussion_r232731480
  
    --- Diff: 
src/java/org/apache/cassandra/net/StartupClusterConnectivityChecker.java ---
    @@ -48,81 +51,133 @@
     {
         private static final Logger logger = 
LoggerFactory.getLogger(StartupClusterConnectivityChecker.class);
     
    -    private final int targetPercent;
    +    private final boolean blockForRemoteDcs;
         private final long timeoutNanos;
     
    -    public static StartupClusterConnectivityChecker create(int 
targetPercent, int timeoutSecs)
    +    public static StartupClusterConnectivityChecker create(long 
timeoutSecs, boolean blockForRemoteDcs)
         {
    -        timeoutSecs = Math.max(1, timeoutSecs);
    +        if (timeoutSecs < 0)
    +            logger.warn("skipping block-for-peers due to negative timeout. 
You may encounter errors or timeouts on" +
    --- End diff --
    
    The reason I thought it was strange was because -1 was a valid config 
option.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to