michaelsembwever commented on a change in pull request #474: Add JAVA_HOME and
java.rmi.server.randomID to the system_properties t…
URL: https://github.com/apache/cassandra/pull/474#discussion_r393139175
##########
File path: src/java/org/apache/cassandra/db/virtual/SystemPropertiesTable.java
##########
@@ -35,6 +35,7 @@
private static final Set<String> CASSANDRA_RELEVANT_PROPERTIES =
Sets.newHashSet(
// base jvm properties
"java.home",
+ "JAVA_HOME",
Review comment:
instead of adding `JAVA_HOME` here, what do you think about adding it to a
second set `CASSANDRA_RELEVANT_ENVS` ? (even if it's a singleton, maybe it's
cleaner code, and allows adding more env more easily…?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
