adelapena commented on a change in pull request #473: Cassandra 15369
URL: https://github.com/apache/cassandra/pull/473#discussion_r404755199
##########
File path: src/java/org/apache/cassandra/db/rows/RangeTombstoneMarker.java
##########
@@ -160,8 +160,8 @@ private DeletionTime currentOpenDeletionTimeInMerged()
return DeletionTime.LIVE;
DeletionTime biggestDeletionTime = openMarkers[biggestOpenMarker];
- // it's only open in the merged iterator if it's not shadowed by
the partition level deletion
- return partitionDeletion.supersedes(biggestDeletionTime) ?
DeletionTime.LIVE : biggestDeletionTime;
+ // it's only open in the merged iterator if it doesn't supersedes
the partition level deletion
+ return !biggestDeletionTime.supersedes(partitionDeletion) ?
DeletionTime.LIVE : biggestDeletionTime;
Review comment:
Do we have a test for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
