dcapwell commented on a change in pull request #721:
URL: https://github.com/apache/cassandra/pull/721#discussion_r478721281
##########
File path: src/java/org/apache/cassandra/fql/FullQueryLogger.java
##########
@@ -117,6 +136,19 @@ public synchronized void enable(Path path, String
rollCycle, boolean blocking, i
}
}
+ public FullQueryLoggerOptions getFullQueryLoggerOptions()
+ {
+ if (isEnabled())
+ {
+ return fullQueryLoggerOptions;
Review comment:
the options should pull from `BinLog` rather than trying to store the
previous `FullQueryLoggerOptions` options; `binLog` field is the source of
truth for FQL
##########
File path: src/java/org/apache/cassandra/utils/binlog/BinLogOptions.java
##########
@@ -18,9 +18,11 @@
package org.apache.cassandra.utils.binlog;
+import java.io.Serializable;
+
import org.apache.commons.lang3.StringUtils;
-public class BinLogOptions
+public class BinLogOptions implements Serializable
Review comment:
should remove `Serializable`, as commented in other comment, not safe to
use for JMX.
##########
File path: src/java/org/apache/cassandra/service/StorageServiceMBean.java
##########
@@ -786,6 +787,10 @@ public StageConcurrency(int corePoolSize, int
maximumPoolSize)
*/
public void stopFullQueryLogger();
+ public boolean isFullQueryLogEnabled();
+
+ public FullQueryLoggerOptions getFullQueryLoggerOptions();
Review comment:
this isn't safe for JMX, should be of types primitive, standard java
serializable class (not guava versions of collections), or CompositeData;
custom classes shouldn't be used in the JMX
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
