dcapwell commented on a change in pull request #728:
URL: https://github.com/apache/cassandra/pull/728#discussion_r479486551
##########
File path: src/java/org/apache/cassandra/metrics/TableMetrics.java
##########
@@ -934,7 +872,7 @@ public Long getValue()
anticompactionTime = createTableTimer("AnticompactionTime",
cfs.keyspace.metric.anticompactionTime);
validationTime = createTableTimer("ValidationTime",
cfs.keyspace.metric.validationTime);
- syncTime = createTableTimer("SyncTime",
cfs.keyspace.metric.repairSyncTime);
+ repairSyncTime = createTableTimer("RepairSyncTime", "RepairSyncTime",
"SyncTime", cfs.keyspace.metric.repairSyncTime);
Review comment:
`SyncTime` is new to 4.0 so don't need to worry about it
https://issues.apache.org/jira/browse/CASSANDRA-13531
Also, SyncTime isn't present when I launch.
Also, 3 strings is confusing, feels like we should just do
`createTableTimer("RepairSyncTime", cfs.keyspace.metric.repairSyncTime);`
##########
File path: src/java/org/apache/cassandra/metrics/TableMetrics.java
##########
@@ -1143,23 +1098,29 @@ protected TableTimer createTableTimer(String name,
Timer keyspaceTimer)
protected TableTimer createTableTimer(String name, String alias, Timer
keyspaceTimer)
{
- Timer cfTimer = Metrics.timer(factory.createMetricName(name),
aliasFactory.createMetricName(alias));
- register(name, alias, cfTimer);
- return new TableTimer(cfTimer,
- keyspaceTimer,
-
Metrics.timer(globalFactory.createMetricName(name),
-
globalAliasFactory.createMetricName(alias)));
+ return createTableTimer(name, alias, null, keyspaceTimer);
}
- protected Timer createTableTimer(String name)
+ protected TableTimer createTableTimer(String name, String alias, String
deprecated, Timer keyspaceTimer)
Review comment:
this method exists for a field which doesn't need `deprecated`, can we
remove?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
