dcapwell commented on a change in pull request #831:
URL: https://github.com/apache/cassandra/pull/831#discussion_r527994984
##########
File path: src/java/org/apache/cassandra/metrics/TableMetrics.java
##########
@@ -62,6 +62,10 @@
*/
public class TableMetrics
{
+ /**
+ * stores metrics that will be rolled into a single global metric
+ */
+ private final static ConcurrentMap<String, Set<Metric>> ALL_TABLE_METRICS
= Maps.newConcurrentMap();
Review comment:
renamed to all caps so its more clear this is global and not local to
the table; seems that this naming convention caused `all` to be confused with
local table names rather than global metrics, so switch to java naming
convention to help to prevent this next time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
