bereng commented on a change in pull request #835:
URL: https://github.com/apache/cassandra/pull/835#discussion_r530960218
##########
File path: src/java/org/apache/cassandra/db/transform/BaseIterator.java
##########
@@ -83,14 +87,31 @@
public final void close()
{
+ // If close has already been called we want to ignore other calls
+ if (closed)
Review comment:
Unless I am missing sthg: I'd wrap everything in a try-finally block and
toggle `closed` to true only there. That is when it is indeed closed and not
'closing' as it is at this point. I can see the code _tries_ to catch/handle
all failures but `runOnClose()` is abstract to be implemented in any way.
That would prevent a failed close operation to toggle the `closed` variable
erroneously.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
