smiklosovic commented on a change in pull request #844:
URL: https://github.com/apache/cassandra/pull/844#discussion_r538765456
##########
File path: src/java/org/apache/cassandra/index/Index.java
##########
@@ -426,6 +426,16 @@ public Indexer indexerFor(DecoratedKey key,
WriteContext ctx,
IndexTransaction.Type transactionType);
+ /**
+ * Tells whether this index supports replica fitering protection or not.
+ *
+ * @return true if this index supports replica filtering protection, false
otherwise
+ */
+ default boolean supportsReplicaFilteringProtection()
+ {
+ return true;
Review comment:
@adelapena @maedhroz is not it true that as of today, all indexes are
supporting filtering protection but SASI does not? All implementations of a
custom index do support filtering based on the current code as it is, only SASI
does not so having this on "false" as default does not make sense to me. We
would have to go over all impls of indexes and change it to true there or I am
missing something. I would make the default what is used more frequently and it
seems we are supporting filtering for all indexes but not sasi ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
