grighetto commented on a change in pull request #5:
URL: https://github.com/apache/cassandra-harry/pull/5#discussion_r538852909



##########
File path: pom.xml
##########
@@ -179,6 +180,13 @@
                 <artifactId>hamcrest-all</artifactId>
                 <version>1.3</version>
             </dependency>
+
+            <!-- this should only be included in the uber jar for standalone 
execution or as a test dep -->
+            <dependency>
+                <groupId>ch.qos.logback</groupId>
+                <artifactId>logback-classic</artifactId>
+                <version>1.2.3</version>
+            </dependency>

Review comment:
       we include this in the harry-integration-external uber jar for 
standalone execution




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to