ifesdjeen commented on a change in pull request #828:
URL: https://github.com/apache/cassandra/pull/828#discussion_r539129322
##########
File path: build-shaded-dtest-jar.sh
##########
@@ -2,12 +2,17 @@
set -xe
-# Cassandra version that is specified in build.xml
-CASSANDRA_VERSION=$1
-# In-JVM dtest version that is specified in relocate-dependencies.pom
-DTEST_VERSION=$2
+cp .//build/lib/jars/reflections-0.9.12.jar ./lib
+cp .//build/lib/jars/javassist-3.26.0-GA.jar ./lib
+
ARTIFACT_NAME=cassandra-dtest
REPO_DIR=~/.m2/repository
+CASSANDRA_VERSION=$(cat build.xml | grep 'property name="base.version"' | awk
-F "\"" '{print $4}')
+DTEST_VERSION=$(cat relocate-dependencies.pom | grep "dtest-local.version>" |
awk -F "\>|\<" '{print $3}')
Review comment:
@dcapwell the point of this patch was specifically to avoid anyone to
have to manage this version. I've changed it from `4.0.1-SNAPSHOT` to
`4.0-beta4-SNAPSHOT`, since we'll need to publish it several times. Howver, if
someone either forgets or has different values for the two by mistake, it'll
still work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
