dcapwell commented on a change in pull request #109:
URL: https://github.com/apache/cassandra-dtest/pull/109#discussion_r546062947



##########
File path: upgrade_tests/cql_tests.py
##########
@@ -4122,6 +4122,7 @@ def test_static_columns_with_2i(self):
 
         cursor.execute("CREATE INDEX ON test(v)")
 
+        from_ver = float(self.UPGRADE_PATH.starting_meta.family)

Review comment:
       just checked, the following are current family versions
   
   ```
   family='2.1'
   family='3.0'
   family='3.11'
   family='trunk'
   ```
   
   so the last one would break as trunk isn't a valid float.  
   
   What we can do is the following
   
   after `self.prepare` do
   
   ```
   initial_version = self.cluster.version()
   ```
   
   then change the if check to
   
   ```
   if initial_version  > LooseVersion('3.0'):
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to