yifan-c commented on a change in pull request #856:
URL: https://github.com/apache/cassandra/pull/856#discussion_r561609392
##########
File path:
test/unit/org/apache/cassandra/tools/nodetool/stats/NodetoolTableStatsTest.java
##########
@@ -78,11 +78,14 @@ public void testMaybeChangeDocs()
" [(-pp | --print-port)] [(-pw
<password> | --password <password>)]\n" +
" [(-pwf <passwordFilePath> |
--password-file <passwordFilePath>)]\n" +
" [(-u <username> | --username
<username>)] tablestats\n" +
- " [(-F <format> | --format <format>)]
[(-H | --human-readable)] [-i]\n" +
- " [(-s <sort_key> | --sort <sort_key>)]
[(-t <top> | --top <top>)] [--]\n" +
- " [<keyspace.table>...]\n" +
+ " [(-B | --boundary-check)] [(-F
<format> | --format <format>)]\n" +
+ " [(-H | --human-readable)] [-i] [(-s
<sort_key> | --sort <sort_key>)]\n" +
+ " [(-t <top> | --top <top>)] [--]
[<keyspace.table>...]\n" +
"\n" +
- "OPTIONS\n" +
+ "OPTIONS\n" +
+ " -B, --boundary-check\n" +
Review comment:
Not sure if there is a rule. The nodetool options naming does not seem
to be very consistent among all the commands.
I do not have preferences. Lower-case sounds good to me. It is a more common
pattern for general cli.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
