michaelsembwever commented on a change in pull request #115:
URL: https://github.com/apache/cassandra-dtest/pull/115#discussion_r564031176
##########
File path: .travis.yml
##########
@@ -1,21 +1,23 @@
language: python
python:
- - "2.7"
+ - "3.8"
install:
- - pip install pycodestyle==2.3.1 flake8
+ - pip install pycodestyle==2.6.0 flake8
- pip check
+ - CASS_DRIVER_NO_CYTHON=1 pip install -r requirements.txt
script:
# we want pyflakes to check all files for unused imports only
# we use flake8 because it allows us to ignore other warnings
# exclude the thrift directories - they contain auto-generated code
- - flake8 --ignore=E501,F811,F812,F822,F823,F831,F841,N8,C9
--exclude=thrift_bindings,cassandra-thrift .
+ # - flake8 --ignore=E501,F811,F812,F822,F823,F831,F841,N8,C9
--exclude=thrift_bindings,cassandra-thrift .
- git remote add apache git://github.com/apache/cassandra-dtest.git
- git fetch apache # fetch master for the next diff
# feed changed lines with no context around them to pycodestyle
# I know we don't enforce line length but if you introduce
# 200-char lines you are doing something terribly wrong.
# lint all files for everything but line length errors
- - git diff apache/master...HEAD -U0 | pycodestyle --ignore=E501 --diff
+ - git diff apache/trunk...HEAD -U0 | pycodestyle --ignore=E501 --diff
# lint all files except json_test.py for line length errors
- - git diff apache/master...HEAD -U0 | pycodestyle --diff
--exclude='json_test.py' --exclude='meta_tests/assertion_test.py'
--max-line-length=200
+ - git diff apache/trunk...HEAD -U0 | pycodestyle --diff
--exclude='json_test.py' --exclude='meta_tests/assertion_test.py'
--max-line-length=200
+ - pytest --metatests
Review comment:
💪
##########
File path: .travis.yml
##########
@@ -1,21 +1,23 @@
language: python
python:
- - "2.7"
+ - "3.8"
install:
- - pip install pycodestyle==2.3.1 flake8
+ - pip install pycodestyle==2.6.0 flake8
- pip check
+ - CASS_DRIVER_NO_CYTHON=1 pip install -r requirements.txt
script:
# we want pyflakes to check all files for unused imports only
# we use flake8 because it allows us to ignore other warnings
# exclude the thrift directories - they contain auto-generated code
- - flake8 --ignore=E501,F811,F812,F822,F823,F831,F841,N8,C9
--exclude=thrift_bindings,cassandra-thrift .
+ # - flake8 --ignore=E501,F811,F812,F822,F823,F831,F841,N8,C9
--exclude=thrift_bindings,cassandra-thrift .
Review comment:
instead of commenting it out, could we add more ignores (for those
currently failing?)
##########
File path: .travis.yml
##########
@@ -1,21 +1,23 @@
language: python
python:
- - "2.7"
+ - "3.8"
install:
- - pip install pycodestyle==2.3.1 flake8
+ - pip install pycodestyle==2.6.0 flake8
- pip check
+ - CASS_DRIVER_NO_CYTHON=1 pip install -r requirements.txt
script:
# we want pyflakes to check all files for unused imports only
# we use flake8 because it allows us to ignore other warnings
# exclude the thrift directories - they contain auto-generated code
- - flake8 --ignore=E501,F811,F812,F822,F823,F831,F841,N8,C9
--exclude=thrift_bindings,cassandra-thrift .
+ # - flake8 --ignore=E501,F811,F812,F822,F823,F831,F841,N8,C9
--exclude=thrift_bindings,cassandra-thrift .
Review comment:
instead of commenting it out, could we add more ignores (for those
currently failing?)
(duplicate and comment out the line so we know what it is supposed to be)
##########
File path: .travis.yml
##########
@@ -1,21 +1,23 @@
language: python
python:
- - "2.7"
+ - "3.8"
install:
- - pip install pycodestyle==2.3.1 flake8
+ - pip install pycodestyle==2.6.0 flake8
- pip check
+ - CASS_DRIVER_NO_CYTHON=1 pip install -r requirements.txt
script:
# we want pyflakes to check all files for unused imports only
# we use flake8 because it allows us to ignore other warnings
# exclude the thrift directories - they contain auto-generated code
- - flake8 --ignore=E501,F811,F812,F822,F823,F831,F841,N8,C9
--exclude=thrift_bindings,cassandra-thrift .
+ # - flake8 --ignore=E501,F811,F812,F822,F823,F831,F841,N8,C9
--exclude=thrift_bindings,cassandra-thrift .
Review comment:
> I can spend 1-2 hours on fixing that properly
i have a PR somewhere for that :-)
(it would need to be a separate ticket.)
let's just comment out the line then for now 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
