yifan-c commented on pull request #868: URL: https://github.com/apache/cassandra/pull/868#issuecomment-768443216
> Efficiency wise I'm not sure all the extra argument passing is better than a null check. I'll see what I can do to improve it. Thanks for the feedback. They are not about solving the same problem. The extra argument and the testing-only method is to separate out the testing code in `Message.java`. The null check is needed as long as response serializer is fetched. The response serializer can be null if the message has expired. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
