tlasica commented on a change in pull request #117:
URL: https://github.com/apache/cassandra-dtest/pull/117#discussion_r566628751
##########
File path: bootstrap_test.py
##########
@@ -280,6 +280,28 @@ def
test_consistent_range_movement_true_with_rf1_should_fail(self):
def test_consistent_range_movement_false_with_rf1_should_succeed(self):
self._bootstrap_test_with_replica_down(False, rf=1)
+ def test_RF_GT_Nodes_should_succeed(self):
+ cluster = self.cluster
+
cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
'True')
+ cluster.populate([2, 2])
+ cluster.start()
+
+ node1 = cluster.nodelist()[0]
+ session = self.patient_cql_connection(node1)
+ session.execute("CREATE KEYSPACE k WITH REPLICATION = {'class' :
'NetworkTopologyStrategy', 'dc1' : '3'}")
+
+ node5 = Node('node5',
Review comment:
nit: using parameter names would make it probably easier to read
##########
File path: bootstrap_test.py
##########
@@ -280,6 +280,28 @@ def
test_consistent_range_movement_true_with_rf1_should_fail(self):
def test_consistent_range_movement_false_with_rf1_should_succeed(self):
self._bootstrap_test_with_replica_down(False, rf=1)
+ def test_RF_GT_Nodes_should_succeed(self):
Review comment:
is having multiple DCs essential for this problem?
If so then maybe it should be reflected in the test name?
##########
File path: bootstrap_test.py
##########
@@ -280,6 +280,28 @@ def
test_consistent_range_movement_true_with_rf1_should_fail(self):
def test_consistent_range_movement_false_with_rf1_should_succeed(self):
self._bootstrap_test_with_replica_down(False, rf=1)
+ def test_RF_GT_Nodes_should_succeed(self):
+ cluster = self.cluster
+
cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED',
'True')
+ cluster.populate([2, 2])
+ cluster.start()
+
+ node1 = cluster.nodelist()[0]
+ session = self.patient_cql_connection(node1)
+ session.execute("CREATE KEYSPACE k WITH REPLICATION = {'class' :
'NetworkTopologyStrategy', 'dc1' : '3'}")
+
+ node5 = Node('node5',
+ cluster,
+ True,
+ ('127.0.0.5', 9160),
+ ('127.0.0.5', 7000),
+ '7500',
+ '0',
+ None,
+ binary_interface=('127.0.0.5', 9042))
+ cluster.add(node5, is_seed=False, data_center="dc1")
Review comment:
Probably too much, but
should we add a failed read before / successful read after addition?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
