blerer commented on a change in pull request #883:
URL: https://github.com/apache/cassandra/pull/883#discussion_r566907931
##########
File path: test/unit/org/apache/cassandra/tools/cqlsh/CqlshTest.java
##########
@@ -44,4 +48,29 @@ public void testKeyspaceRequired()
assertThat(tool.getCleanedStderr(),
CoreMatchers.containsStringIgnoringCase("No keyspace has been specified"));
assertEquals(2, tool.getExitCode());
}
+
+ @Test
+ public void testUseUnreservedKeywordAsColumnName()
+ {
+ List<String> names = Arrays.asList("access", "datacenters");
+ for (String name : names)
+ {
+ testUseUnreservedKeywordAsColumnName(name);
+ testUseUnreservedKeywordAsColumnName(name.toUpperCase());
+ }
+ }
Review comment:
nit: I would have put that test into `CreateTest`. I would not think of
looking into CqlshTest for a test on unreserved Keywords.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
