adelapena commented on a change in pull request #870:
URL: https://github.com/apache/cassandra/pull/870#discussion_r566935391
##########
File path: test/unit/org/apache/cassandra/schema/CreateTableValidationTest.java
##########
@@ -81,7 +80,10 @@ public void testCreateKeyspaceTableWarning() throws
IOException
DatabaseDescriptor.setKeyspaceCountWarnThreshold(Schema.instance.getKeyspaces().size()
+ 1);
query = new QueryMessage(String.format(createKeyspace, 2),
QueryOptions.DEFAULT);
resp = client.execute(query);
- assertTrue(resp.getWarnings() == null ||
resp.getWarnings().isEmpty());
+ List<String> warns = resp.getWarnings();
+ if (warns != null)
+ warns.removeIf(s -> s.contains("is higher than the number of
nodes"));
Review comment:
I understand that we still have warnings here despite of having a RF=1
because of the RF of `system_distributed` and `system_traces`. Indeed, when we
run a single instance we always have warnings for those in the logs. I'm
wondering whether it would make sense to not emit the warning for system
keyspaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
