tlasica commented on a change in pull request #122:
URL: https://github.com/apache/cassandra-dtest/pull/122#discussion_r572657544
##########
File path: upgrade_tests/upgrade_manifest.py
##########
@@ -126,17 +126,17 @@ def clone_with_local_env_version(self):
return self._replace(version="clone:{}".format(cassandra_dir))
-indev_2_1_x = VersionMeta(name='indev_2_1_x', family='2.1', variant='indev',
version='github:apache/cassandra-2.1', min_proto_v=1, max_proto_v=3,
java_versions=(7, 8))
-current_2_1_x = VersionMeta(name='current_2_1_x', family='2.1',
variant='current', version='2.1.20', min_proto_v=1, max_proto_v=3,
java_versions=(7, 8))
+indev_2_1_x = VersionMeta(name='indev_2_1_x', family='2.1.x', variant='indev',
version='github:apache/cassandra-2.1', min_proto_v=1, max_proto_v=3,
java_versions=(7, 8))
Review comment:
`VersionMeta` should throw assertion if `family` is not withing defined
families
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
