dcapwell commented on a change in pull request #889:
URL: https://github.com/apache/cassandra/pull/889#discussion_r574865893
##########
File path:
test/distributed/org/apache/cassandra/distributed/test/hostreplacement/AssassinateAbruptDownedNodeTest.java
##########
@@ -36,4 +40,20 @@ void consume(Cluster cluster, IInvokableInstance
nodeToRemove)
{
stopAbrupt(cluster, nodeToRemove);
}
+
+ @Override
+ protected void afterNodeStatusIsLeft(Cluster cluster, IInvokableInstance
removedNode)
+ {
+ // Check it is possible to alter keyspaces (see CASSANDRA-16422)
+
+ // First, make sure the node is convicted so the gossiper considers it
unreachable
+ InetSocketAddress socketAddress =
removedNode.config().broadcastAddress();
+ InetAddressAndPort removedEndpoint =
InetAddressAndPort.getByAddressOverrideDefaults(socketAddress.getAddress(),
+
socketAddress.getPort());
+ cluster.get(BaseAssassinatedCase.SEED_NUM).runOnInstance(() ->
Gossiper.instance.convict(removedEndpoint, 1.0));
+
+ // Second, try and alter the keyspace. Before the bug was fixed, this
would fail as the check includes
+ // unreachable nodes that could have LEFT status.
+ cluster.schemaChangeIgnoringStoppedInstances(String.format("ALTER
KEYSPACE %s WITH DURABLE_WRITES = false", KEYSPACE));
Review comment:
bad comment, only tables can do that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
