tlasica commented on a change in pull request #123:
URL: https://github.com/apache/cassandra-dtest/pull/123#discussion_r579095740
##########
File path: upgrade_tests/upgrade_through_versions_test.py
##########
@@ -46,7 +48,10 @@ def data_writer(tester, to_verify_queue,
verification_done_queue, rewrite_probab
def handle_sigterm(signum, frame):
# need to close queue gracefully if possible, or the data_checker
process
# can't seem to empty the queue and test failures result.
+ logger.info("Data writer process terminating, closing queues")
to_verify_queue.close()
Review comment:
nit: we may wrap
```
def cleanup():
to_verify_queue.close()
verification_done_queue.close()
session.shutdown()
```
and call it in both `handle_sigterm()` and on exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
