iamaleksey commented on a change in pull request #898:
URL: https://github.com/apache/cassandra/pull/898#discussion_r579285754
##########
File path:
src/java/org/apache/cassandra/db/filter/ClusteringIndexSliceFilter.java
##########
@@ -56,6 +56,20 @@ public boolean selectsAllPartition()
return slices.size() == 1 && !slices.hasLowerBound() &&
!slices.hasUpperBound();
}
+ public boolean isEmpty(ClusteringComparator comparator)
+ {
+ if (slices.isEmpty())
+ return true;
+
+ for (Slice slice : slices)
+ {
+ if (slice.isEmpty(comparator))
+ return true;
Review comment:
This is a bit wrong, if only one or some of the slices is empty, but not
all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
