jacek-lewandowski commented on a change in pull request #1031:
URL: https://github.com/apache/cassandra/pull/1031#discussion_r643881676
##########
File path:
test/unit/org/apache/cassandra/db/SSTableAndMemTableDigestMatchTest.java
##########
@@ -114,27 +148,47 @@ private void testWithFilter(Function<TableMetadata,
ColumnFilter> filterFactory)
execute("INSERT INTO %s (k, v1, v2, m) values (?, ?, ?, ?) USING
TIMESTAMP ?", 1, 2, 3, m, writeTime);
ColumnFamilyStore cfs = getCurrentColumnFamilyStore();
- ColumnFilter filter = filterFactory.apply(cfs.metadata());
- String digest1 = getDigest(filter);
+
assertDigestsAreEqualsBeforeAndAfterFlush(filterFactory.apply(cfs.metadata()),
Clustering.EMPTY);
+ }
+
+ private void testWithFilterAndStaticColumnsOnly(Function<TableMetadata,
ColumnFilter> filterFactory) throws Throwable
+ {
+ createTable("CREATE TABLE %s (pk int, ck int, s1 int static, s2 int
static, v int, PRIMARY KEY(pk, ck))");
+ execute("INSERT INTO %s (pk, s1, s2) VALUES (1, 1, 1) USING TIMESTAMP
1000");
+ flush();
+ execute("INSERT INTO %s (pk, s1) VALUES (1, 2) USING TIMESTAMP 2000");
+ flush();
+ execute("DELETE s1 FROM %s USING TIMESTAMP 3000 WHERE pk = 1");
+ flush();
+
+ ColumnFamilyStore cfs = getCurrentColumnFamilyStore();
+
assertDigestsAreEqualsBeforeAndAfterFlush(filterFactory.apply(cfs.metadata()));
Review comment:
Using this assertion this way does not bring much value because the data
is already flushed - so we check digest, flush again (but there nothing to
flush, so this is no-op) and check digest.
I suggest replacing each flush in this test with this assertion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
