ekaterinadimitrova2 commented on a change in pull request #1038: URL: https://github.com/apache/cassandra/pull/1038#discussion_r645652944
########## File path: test/unit/org/apache/cassandra/cql3/ViewComplexLivenessTest.java ########## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.cql3; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.List; + +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +import org.apache.cassandra.db.ColumnFamilyStore; +import org.apache.cassandra.db.Keyspace; +import org.apache.cassandra.transport.ProtocolVersion; +import org.apache.cassandra.utils.FBUtilities; + +import static org.apache.cassandra.cql3.ViewComplexTest.createView; +import static org.apache.cassandra.cql3.ViewComplexTest.updateView; +import static org.apache.cassandra.cql3.ViewComplexTest.updateViewWithFlush; +import static org.junit.Assert.assertEquals; + +/* This class been split into multiple ones bc of timeout issues CASSANDRA-16670 Review comment: This is a super nit but I just realized we say we split a test into tests that include also this one...reads weird :-) We can copy-paste this everywhere ########## File path: test/unit/org/apache/cassandra/cql3/ViewComplexLivenessTest.java ########## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.cql3; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.List; + +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +import org.apache.cassandra.db.ColumnFamilyStore; +import org.apache.cassandra.db.Keyspace; +import org.apache.cassandra.transport.ProtocolVersion; +import org.apache.cassandra.utils.FBUtilities; + +import static org.apache.cassandra.cql3.ViewComplexTest.createView; +import static org.apache.cassandra.cql3.ViewComplexTest.updateView; +import static org.apache.cassandra.cql3.ViewComplexTest.updateViewWithFlush; +import static org.junit.Assert.assertEquals; + +/* This class been split into multiple ones bc of timeout issues CASSANDRA-16670 Review comment: ```suggestion /* ViewComplexTest class has been split into multiple ones because of timeout issues (CASSANDRA-16670) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
