sumanth-pasupuleti commented on a change in pull request #1043:
URL: https://github.com/apache/cassandra/pull/1043#discussion_r646784917
##########
File path: src/java/org/apache/cassandra/cql3/QueryEvents.java
##########
@@ -235,6 +246,15 @@ public void notifyPrepareFailure(@Nullable CQLStatement
statement, String query,
}
}
+ private String possiblyObfuscateQuery(CQLStatement statement, String query)
Review comment:
- Each time we call getAuditLogContext, like you mention, we end up
creating a new instance of AuditLogContext() which seems unnecessary and
something we should avoid, for this purpose of determining when to obfuscate.
- It feels semantically odd to me for QueryEvents to depend on AuditLog*,
given QueryEvents is supposed to be a generic framework which listeners like
AuditLog, FQL depend on.
- Right now, it is just CREATE ROLE, ALTER ROLE, CREATE USER (which is
treated as CREATE ROLE), ALTER USER (which is treated as ALTER ROLE) that use
passwords. We could potentially include all DCLs, but that seems overkill to me
at this point, given how unlikely CQL protocol is to change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
