smiklosovic commented on a change in pull request #1046:
URL: https://github.com/apache/cassandra/pull/1046#discussion_r647774922
##########
File path: src/java/org/apache/cassandra/db/ColumnFamilyStore.java
##########
@@ -1879,6 +1882,15 @@ private void writeSnapshotManifest(final JSONArray
filesJSONArr, final String sn
{
final JSONObject manifestJSON = new JSONObject();
manifestJSON.put("files", filesJSONArr);
+ if (ttl != null) {
+ DateFormat df = new
SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.S'Z'");
Review comment:
I believe this might be all changed by Instant API just by
"Instant.now()"
https://docs.oracle.com/javase/tutorial/datetime/iso/instant.html
Duration ttl = Duration.ofMinutes(5);
Instant now = Instant.now();
String createdAt = now.toString();
String expireAt = now.plus(ttl).toString();
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
