maedhroz commented on a change in pull request #1110:
URL: https://github.com/apache/cassandra/pull/1110#discussion_r671500382
##########
File path: test/unit/org/apache/cassandra/service/reads/DigestResolverTest.java
##########
@@ -78,6 +79,69 @@ public void noRepairNeeded()
assertPartitionsEqual(filter(iter(response)), resolver.getData());
}
+ @Test
+ public void multiThreadedNoRepairNeededReadCallback() throws
InterruptedException
+ {
+ SinglePartitionReadCommand command =
SinglePartitionReadCommand.fullPartitionRead(cfm, nowInSec, dk);
+ EndpointsForToken targetReplicas = EndpointsForToken.of(dk.getToken(),
full(EP1), full(EP2));
+ PartitionUpdate response = update(row(1000, 4, 4), row(1000, 5,
5)).build();
+ ReplicaPlan.SharedForTokenRead plan = plan(ConsistencyLevel.ONE,
targetReplicas);
+
+ ExecutorService pool = Executors.newFixedThreadPool(4);
+
+ try
+ {
+ for (int i = 0; i < 10_000_000; i++)
Review comment:
This test can obviously run for quite a while, but if it doesn't run
long enough to catch the problem, it doesn't add much value. I'm open to
throwing an `@Ignore` on it for now, leaving it to a suite of tests we don't
run on every commit, or any other ideas...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
