belliottsmith commented on a change in pull request #1045:
URL: https://github.com/apache/cassandra/pull/1045#discussion_r679847655
##########
File path: src/java/org/apache/cassandra/net/AbstractMessageHandler.java
##########
@@ -304,12 +302,21 @@ private void onReserveCapacityRegained(Limit
endpointReserve, Limit globalReserv
try
{
/*
- * Process up to one message using supplied overriden reserves -
one of them pre-allocated,
- * and guaranteed to be enough for one message - then, if no
obstacles enountered, reactivate
+ * Process up to one message using supplied overridden reserves -
one of them pre-allocated,
+ * and guaranteed to be enough for one message - then, if no
obstacles encountered, reactivate
* the frame decoder using normal reserve capacities.
*/
- if (processUpToOneMessage(endpointReserve, globalReserve))
- decoder.reactivate();
+ if (!decoder.isActive())
Review comment:
Why has this condition been added? This method should only be invoked on
connections that have been paused due to breaching their memory limits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
