adelapena commented on a change in pull request #1141:
URL: https://github.com/apache/cassandra/pull/1141#discussion_r691156299
##########
File path:
src/java/org/apache/cassandra/index/sasi/analyzer/DelimiterAnalyzer.java
##########
@@ -56,14 +57,16 @@ public ByteBuffer next()
return iter.next();
}
+ public void validate(Map<String, String> options, AbstractType validator)
throws ConfigurationException
+ {
+ if (!VALID_ANALYZABLE_TYPES.containsKey(validator))
+ throw new ConfigurationException(String.format("Only text types
supported, got %s", validator));
Review comment:
I missed that one. However, I still don't see a use case where that
second configuration exception could be raised, since SASI doesn't support
non-frozen collections or UDTs. If the exception where reachable I wonder if we
would need a similar check in other text analyzer, and that would make the case
to pass the cell value type, or the entire column definition, to
`AbstractAnalyzer#isCompatibleWith`.
I might be missing something obvious, but I think that this check is a
remanent from what there was before creating the `isCompatibeWith` method
during CASSANDRA-13669. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
