pauloricardomg commented on a change in pull request #69:
URL: https://github.com/apache/cassandra-website/pull/69#discussion_r693980385



##########
File path: src/doc/4.1/_sources/operating/backups.rst.txt
##########
@@ -378,7 +381,19 @@ To take snapshots of multiple tables that are in different 
keyspaces the command
  Requested creating snapshot(s) for [catalogkeyspace.journal,cqlkeyspace.t] 
with snapshot 
  name [multi-ks] and options {skipFlush=false}
  Snapshot directory: multi-ks
- 
+
+Providing TTL for created snapshot
+++++++++++++++++++++++++++++++++++
+One can provide ttl for created snapshot using ``--ttl`` option.TTL can be set 
in minutes (m), seconds (s), hours (h) and other TimeUnits. As an example, 
create snapshots for all tables in ``catalogkeyspace`` and ``cqlkeyspace`` 
keyspaces and set 3 minutes ttl.
+
+::
+
+ [ec2-user@ip-10-0-2-238 ~]$ nodetool snapshot
+ --tag catalog-cql-ks --ttl 3m  catalogkeyspace cqlkeyspace
+ Requested creating snapshot(s) for [catalogkeyspace, cqlkeyspace] with 
snapshot
+ name [catalog-cql-ks] and options {skipFlush=false, ttl=3m}
+ Snapshot directory: catalog-cql-ks

Review comment:
       Please continue example showing the snapshot present when calling 
`nodetool listsnapshots`, then sleep 180 and call `nodetool listsnapshots` and 
show snapshot is no longer present, to illustrate to the user how the feature 
works.

##########
File path: src/doc/4.1/_sources/operating/backups.rst.txt
##########
@@ -378,7 +381,19 @@ To take snapshots of multiple tables that are in different 
keyspaces the command
  Requested creating snapshot(s) for [catalogkeyspace.journal,cqlkeyspace.t] 
with snapshot 
  name [multi-ks] and options {skipFlush=false}
  Snapshot directory: multi-ks
- 
+
+Providing TTL for created snapshot
+++++++++++++++++++++++++++++++++++
+One can provide ttl for created snapshot using ``--ttl`` option.TTL can be set 
in minutes (m), seconds (s), hours (h) and other TimeUnits. As an example, 
create snapshots for all tables in ``catalogkeyspace`` and ``cqlkeyspace`` 
keyspaces and set 3 minutes ttl.

Review comment:
       Please rephrase this to:
   ```
   It's possible to set a time-to-live (TTL) for created snapshot using the 
``--ttl`` option, causing the snapshot to be automatically cleaned up when the 
TTL expires. TTL can be specified in minutes (m), seconds (s), hours (h) and 
days (d).
   
   The example below shows the creation of a snapshot for all tables in the 
``catalogkeyspace`` and ``cqlkeyspace`` keyspaces with a TTL of 3 minutes:
   ```

##########
File path: src/doc/4.1/_sources/operating/backups.rst.txt
##########
@@ -378,7 +381,19 @@ To take snapshots of multiple tables that are in different 
keyspaces the command
  Requested creating snapshot(s) for [catalogkeyspace.journal,cqlkeyspace.t] 
with snapshot 
  name [multi-ks] and options {skipFlush=false}
  Snapshot directory: multi-ks
- 
+
+Providing TTL for created snapshot

Review comment:
       Call Section `Expiring snapshots` and add it to its own section after 
`Listing Snapshots`. This will be important to add other features in the future 
like snapshot cleanup pause and resume.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to