dcapwell commented on a change in pull request #1136:
URL: https://github.com/apache/cassandra/pull/1136#discussion_r695257710
##########
File path: src/java/org/apache/cassandra/service/reads/ReadCallback.java
##########
@@ -105,6 +160,25 @@ public void awaitResults() throws ReadFailureException,
ReadTimeoutException
*/
int received = resolver.responses.size();
boolean failed = failures > 0 && (blockFor > received ||
!resolver.isDataPresent());
+ WarningCounter warnings = warningCounter;
+ if (warnings != null)
+ {
+ if (warnings.tombstoneAborts.get() > 0)
+ {
+ String msg =
tombstoneAbortMessage(warnings.tombstoneAborts.get(),
warnings.maxTombstoneAbortsCount.get(), command.toCQLString());
+ ClientWarn.instance.warn(msg + " with " +
command.loggableTokens());
+ logger.warn(msg);
+ cfs().metric.clientTombstoneAborts.mark();
Review comment:
should we inc if the query doesn't fail? kinda think we should inc at
the throws?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
