maulin-vasavada commented on pull request #1027: URL: https://github.com/apache/cassandra/pull/1027#issuecomment-906816765
@jonmeredith and @tolbertam Thanks for playing around it and verifying. I tried to reproduce what you experienced with the unit test and now I can clearly see what you mean. Based on that I agree with Jon that we should prevent the copied values from being set in the params and throw IllegalArgumentException - basically what we are saying is - if you want to just re-use the existing config keys that exist in the encryption options today, then `do not` set the same keys as parameterized class parameters. I'll add unit test around it to verify the exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
