maedhroz commented on a change in pull request #1176:
URL: https://github.com/apache/cassandra/pull/1176#discussion_r698767494
##########
File path: src/java/org/apache/cassandra/utils/ObjectSizes.java
##########
@@ -133,6 +134,16 @@ public static long sizeOnHeapExcludingData(ByteBuffer
buffer)
return BUFFER_EMPTY_SIZE;
}
+ public static long sizeOfEmptyHeapByteBuffer()
+ {
+ return BUFFER_EMPTY_SIZE;
+ }
Review comment:
Not directly related to your patch, but it seems a bit misleading that
`sizeOnHeapExcludingData()` takes an argument. Perhaps it would be better to be
explicit and just remove it, replacing current usages w/ your new
`sizeOfEmptyHeapByteBuffer()` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
