maedhroz commented on a change in pull request #1180:
URL: https://github.com/apache/cassandra/pull/1180#discussion_r702078481



##########
File path: src/java/org/apache/cassandra/db/ReadCommand.java
##########
@@ -632,6 +654,84 @@ private void maybeDelayForTesting()
         }
     }
 
+    private UnfilteredPartitionIterator 
withQuerySizeTracking(UnfilteredPartitionIterator iterator)

Review comment:
       nit: `withQuerySizeTracking` -> `withResponseSizeTracking`?
   
   Although I might be misunderstanding, in the sense that this isn't really 
about response size over the wire, but the amount of stuff we have to 
materialize on-heap (even if we free partitions or even rows as they are 
consumed?) to create a response...?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to