clohfink commented on a change in pull request #1117:
URL: https://github.com/apache/cassandra/pull/1117#discussion_r704733504
##########
File path:
test/unit/org/apache/cassandra/cql3/validation/entities/VirtualTableTest.java
##########
@@ -53,52 +57,141 @@
private static final String VT2_NAME = "vt2";
private static final String VT3_NAME = "vt3";
- private static class WritableVirtualTable extends AbstractVirtualTable
+ private static class MutableVirtualTable extends
AbstractMutableVirtualTable
{
- private final ColumnMetadata valueColumn;
- private final Map<String, Integer> backingMap = new HashMap<>();
+ // <pk1, pk2> -> c1 -> c2 -> <v1, v2>
+ private final Map<Pair<String, String>, SortedMap<String,
SortedMap<String, Pair<Integer, Long>>>> backingMap = new ConcurrentHashMap<>();
Review comment:
NP: this is really hard to follow, at this depth of generics might be
worth having a POJO to wrap part of it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
