maedhroz commented on a change in pull request #1180:
URL: https://github.com/apache/cassandra/pull/1180#discussion_r706284670
##########
File path: src/java/org/apache/cassandra/transport/Dispatcher.java
##########
@@ -110,6 +114,7 @@ else if (backpressure == Overload.BYTES_IN_FLIGHT)
Message.logger.trace("Received: {}, v={}", request,
connection.getVersion());
connection.requests.inc();
Message.Response response = request.execute(qstate,
queryStartNanoTime);
+ CoordinatorTrackWarnings.done();
Review comment:
Is `done()` not called if there is an exception thrown from `execute()`.
One thing we might consider is looking at moving the `init()`/`done()` pair to
`Message.Request#execute()`, where tracing is enabled. (i.e. There is already
some plumbing there to do something conceptually similar for tracing, and tbh,
if we ever try to have a more unified thread-local query context, that would
make things easier to pull together.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
