josh-mckenzie commented on a change in pull request #1182:
URL: https://github.com/apache/cassandra/pull/1182#discussion_r707373753
##########
File path: src/java/org/apache/cassandra/db/marshal/CollectionType.java
##########
@@ -199,6 +199,15 @@ public boolean
isValueCompatibleWithInternal(AbstractType<?> previous)
return isValueCompatibleWithFrozen(tprev);
}
+ @Override
+ public boolean isSerializationCompatibleWith(AbstractType<?> previous)
+ {
+ if (!isValueCompatibleWith(previous))
+ return false;
+
+ return
valueComparator().isSerializationCompatibleWith(((CollectionType)previous).valueComparator());
Review comment:
:+1: Changed on branch. Thanks.
##########
File path:
test/distributed/org/apache/cassandra/distributed/test/NetstatsRepairStreamingTest.java
##########
@@ -76,7 +76,7 @@ private void executeTest(boolean compressionEnabled) throws
Exception
final Future<NetstatResults> resultsFuture1 =
executorService.submit(new NetstatsCallable(node1));
- node1.nodetoolResult("repair",
"netstats_test").asserts().success();
+ node1.nodetoolResult("repair", "--full",
"netstats_test").asserts().success();
Review comment:
Nope - slipped through from another diff. I'll fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
