alex-ninja commented on a change in pull request #1189:
URL: https://github.com/apache/cassandra/pull/1189#discussion_r710216945
##########
File path: src/java/org/apache/cassandra/db/ColumnFamilyStore.java
##########
@@ -1524,7 +1524,11 @@ public SSTableReader
getMaxSizeFile(Iterable<SSTableReader> sstables)
{
// skip snapshot creation during scrub, SEE JIRA 5891
if(!disableSnapshot)
- snapshotWithoutFlush("pre-scrub-" + System.currentTimeMillis());
+ {
+ long timestamp = System.currentTimeMillis();
+ String snapshotName = "pre-scrub-" + timestamp;
+ snapshotWithoutFlush(snapshotName, null, false, null, null,
timestamp);
Review comment:
I think now we can re-use the newly created method:
```
snapshotWithoutFlush(snapshotName, timestamp);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
