maedhroz commented on a change in pull request #161:
URL: https://github.com/apache/cassandra-dtest/pull/161#discussion_r710321911
##########
File path: tools/data.py
##########
@@ -17,14 +17,17 @@ def create_c1c2_table(tester, session, read_repair=None):
create_cf(session, 'cf', columns={'c1': 'text', 'c2': 'text'},
read_repair=read_repair)
-def insert_c1c2(session, keys=None, n=None,
consistency=ConsistencyLevel.QUORUM):
+def insert_c1c2(session, ks=None, keys=None, n=None,
consistency=ConsistencyLevel.QUORUM):
if (keys is None and n is None) or (keys is not None and n is not None):
raise ValueError("Expected exactly one of 'keys' or 'n' arguments to
not be None; "
"got keys={keys}, n={n}".format(keys=keys, n=n))
if n:
keys = list(range(n))
- statement = session.prepare("INSERT INTO cf (key, c1, c2) VALUES (?,
'value1', 'value2')")
+ fully_qualified_cf = "cf"
+ if ((ks is not None) and (not ks)):
Review comment:
Doesn't `not ks` mean the string is empty? i.e. This conditional says
"ks is not None but it is empty"
Do we want something like `if ((ks is not None) and ks != ""):` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
