jyothsnakonisa opened a new pull request #16: URL: https://github.com/apache/cassandra-diff/pull/16
This Pull Request fixes two bugs that surfaced during retrying diff jobs with same JobId. 1. The try resource block in DiffJob.java closes the session object before the code in exception or finally block gets executed. We are marking the job as not running in the exception block which throws an exception as the session object is already closed. Chaning the resource try catch block to try catch finally block so that session object will not be closed until cleanup is complete. 2. When job_id is passed as a config property for the first time, we will not have metadata associated with job_id in metadata table but the current code attempts to get the job metadata for the passed jobId and as those details will not be present, a null pointer exception is thrown. This Pr fixes this issue by getting jobParameters from the table only when they are available otherwise creates new job parameters with passed JobId or random UUID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
