sumanth-pasupuleti commented on a change in pull request #1229:
URL: https://github.com/apache/cassandra/pull/1229#discussion_r725645009
##########
File path: test/unit/org/apache/cassandra/config/DatabaseDescriptorTest.java
##########
@@ -590,4 +590,23 @@ public void
testApplyTokensConfigInitialTokensOneNumTokensNotSet()
Assert.assertEquals(Integer.valueOf(1), config.num_tokens);
Assert.assertEquals(1,
DatabaseDescriptor.tokensFromString(config.initial_token).size());
}
+
+ @Test (expected = ConfigurationException.class)
+ public void testInvalidSub1DefaultRFs() throws ConfigurationException
+ {
+ DatabaseDescriptor.setDefaultKeyspaceRF(0);
+ }
+
+ @Test (expected = ConfigurationException.class)
+ public void testInvalidSub0MinimumRFs() throws ConfigurationException
+ {
+ DatabaseDescriptor.setMinimumKeyspaceRF(-1);
+ }
+
+ @Test (expected = ConfigurationException.class)
+ public void testDefaultRfLessThanMinRF()
Review comment:
Added additional test case "testMinimumRfGreaterThanDefaultRF" with
regards to the prior comment.
Regarding the latter comment, that condition is covered by
testDefaultRfLessThanMinRF()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
