josh-mckenzie commented on a change in pull request #1249:
URL: https://github.com/apache/cassandra/pull/1249#discussion_r728217784
##########
File path: src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java
##########
@@ -113,7 +112,6 @@ public CorruptTransactionLogException(String message,
LogFile txnFile)
private final Object lock;
private final Ref<LogTransaction> selfRef;
// Deleting sstables is tricky because the mmapping might not have been
finalized yet,
Review comment:
nit: terminate with period.
##########
File path: src/java/org/apache/cassandra/utils/NativeLibrary.java
##########
@@ -143,10 +140,8 @@ private static OSType getOsType()
return LINUX;
else if (osName.contains("mac"))
return MAC;
- else if (osName.contains("windows"))
- return WINDOWS;
- logger.warn("the current operating system, {}, is unsupported by
cassandra", osName);
+ logger.warn("the current operating system, {}, is unsupported by
Cassandra", osName);
Review comment:
Have we checked to confirm that, on windows under WSL, osType comes up
as LINUX?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
