josh-mckenzie commented on a change in pull request #1213:
URL: https://github.com/apache/cassandra/pull/1213#discussion_r731032261
##########
File path: src/java/org/apache/cassandra/service/StorageProxyMBean.java
##########
@@ -63,6 +63,19 @@
@Deprecated
public int getOtcBacklogExpirationInterval();
+
+ public void loadPartitionDenylist();
+ public int getPartitionDenylistLoadAttempts();
+ public int getPartitionDenylistLoadSuccesses();
+ public void setEnablePartitionDenylist(boolean enabled);
Review comment:
For the 4 "set" methods (global on/off denylist, writes, reads, range
reads) there's no immediate use-case (or requirement I've seen w/the usage of
this feature) that necessitates a read-before-write in terms of checking
whether this feature is enabled or not. i.e. There's no "IF writes are enabled,
THEN enable reads" or "IF writes are enabled, THEN disable write denylisting".
From an operator troubleshooting perspective the log entries around denied keys
as well as metrics both serve to indicate whether blocking is going or not.
So we could certainly add a JMX hook to allow people to query the state of
denylisting on the node if you think there's a credible use-case to need that,
but at least for now it's in pursuit of keeping the API surface area small in
the face of YAGNI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
