maedhroz commented on a change in pull request #1204:
URL: https://github.com/apache/cassandra/pull/1204#discussion_r743199846



##########
File path: src/java/org/apache/cassandra/auth/AuthCache.java
##########
@@ -78,6 +94,8 @@ public static void shutdownAllAndWait(long timeout, TimeUnit 
unit) throws Interr
      * @param getUpdateIntervalDelegate Getter for update interval
      * @param setMaxEntriesDelegate Used to set max # entries in cache. See 
{@link com.github.benmanes.caffeine.cache.Policy.Eviction#setMaximum(long)}
      * @param getMaxEntriesDelegate Getter for max entries.
+     * @param setActiveUpdate Actively update the cache before expiry

Review comment:
       nit: Would this make more sense as something like "Set whether or not 
cache updates actively before expiry" or "Sets whether or not cache updates 
independent of expiry"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to