bereng commented on a change in pull request #1342:
URL: https://github.com/apache/cassandra/pull/1342#discussion_r758962779
##########
File path: test/unit/org/apache/cassandra/utils/RecomputingSupplierTest.java
##########
@@ -93,31 +89,40 @@ public void recomputingSupplierTest() throws Throwable
lastSeen.accumulateAndGet(v, Math::max);
Assert.assertTrue(String.format("Seen %d out of
order. Last seen value %d", v, seenBeforeGet),
v >= seenBeforeGet);
-
}
-
}
catch (Throwable e)
{
thrown.set(e);
- latch.countDown();
}
}
});
}
- latch.await(10, TimeUnit.SECONDS);
-
+ Util.spinAssertEquals(true, () -> {return counter.get() > 1;}, 11);
testExecutor.shutdown();
- testExecutor.awaitTermination(10, TimeUnit.SECONDS);
- executor.shutdown();
- executor.awaitTermination(10, TimeUnit.SECONDS);
+ Assert.assertTrue(testExecutor.awaitTermination(11, TimeUnit.SECONDS));
Review comment:
Part of a left over from a previous approach where I had 10 threads
sleeping 1s, hence I was waiting 11s. We can change it to 10 which reads better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
