yifan-c commented on a change in pull request #1311:
URL: https://github.com/apache/cassandra/pull/1311#discussion_r760492845
##########
File path: src/java/org/apache/cassandra/config/DatabaseDescriptor.java
##########
@@ -2076,6 +2076,13 @@ public static int getCommitLogSegmentSize()
return (int)
ByteUnit.MEBI_BYTES.toBytes(conf.commitlog_segment_size_in_mb);
}
+ /**
+ * Update commitlog_segment_size_in_mb in the tests.
+ * {@link CommitLogSegmentManagerCDC} uses the CommitLogSegmentSize to
estimate the file size on allocation.
+ * It is important to keep the value unchanged for the estimation to be
correct.
+ * @param sizeMegabytes
+ */
+ @VisibleForTesting /* Only for testing */
Review comment:
yeah. I think we mostly use the annotation `@VisibleForTesting` for the
purpose of OnlyForTesting. Since it covers a lot of the methods, creating a
dedicated ticket for it feel better. I will make a new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
