adelapena commented on a change in pull request #1348:
URL: https://github.com/apache/cassandra/pull/1348#discussion_r761834790
##########
File path:
test/unit/org/apache/cassandra/db/compaction/CompactionsBytemanTest.java
##########
@@ -127,9 +128,10 @@ public void testCompactingCFCounting() throws Throwable
cfs.enableAutoCompaction();
execute("INSERT INTO %s (k, c, v) VALUES (?, ?, ?)", 0, 1, 1);
- assertEquals(0, CompactionManager.instance.compactingCF.count(cfs));
+ Util.spinAssertEquals(true, () -> {return
CompactionManager.instance.compactingCF.count(cfs) == 0;}, 1);
Review comment:
Increasing to 10s or even more sounds good given our experience with
timeouts. I understand that the 1s timeout matches the 1s delay injected by the
Byteman rule, is this right? In that case we should also increase the Byteman
delay, so the delay >= timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
