jacek-lewandowski commented on a change in pull request #1276:
URL: https://github.com/apache/cassandra/pull/1276#discussion_r769073742
##########
File path: src/java/org/apache/cassandra/io/sstable/Descriptor.java
##########
@@ -51,42 +49,44 @@
public static String TMP_EXT = ".tmp";
- private static final Splitter filenameSplitter = Splitter.on('-');
+ public static final char FILENAME_SEPARATOR = '-';
+
+ private static final Splitter filenameSplitter =
Splitter.on(FILENAME_SEPARATOR);
/** canonicalized path to the directory where SSTable resides */
public final File directory;
/** version has the following format: <code>[a-z]+</code> */
public final Version version;
public final String ksname;
public final String cfname;
- public final int generation;
+ public final SSTableId generation;
Review comment:
hmm.... this will make this commit quite large comparing to what it
does; if we really need it, I'd not do that in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
