blerer commented on a change in pull request #1362:
URL: https://github.com/apache/cassandra/pull/1362#discussion_r773926028
##########
File path: src/java/org/apache/cassandra/transport/ConnectedClient.java
##########
@@ -128,10 +137,20 @@ private SslHandler sslHandler()
public Map<String, String> asMap()
{
+ String clientOptionsJSON;
+ ObjectMapper objMapper = new ObjectMapper();
+ try
+ {
+ clientOptionsJSON =
objMapper.writeValueAsString(clientOptions().get());
+ } catch(JsonProcessingException e)
+ {
+ clientOptionsJSON = UNDEFINED;
+ }
Review comment:
We do not normally use json libraries for that type of things. It is
also more readable to us Guava Joiner:
` Joiner.on(',').withKeyValueSeparator("=").join(clientOptions().get())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
